Skip to content

Added Alpine 3.14#1498

Merged
nschonni merged 1 commit intonodejs:mainfrom
xmikus01:added-alpine3.14
Jul 8, 2021
Merged

Added Alpine 3.14#1498
nschonni merged 1 commit intonodejs:mainfrom
xmikus01:added-alpine3.14

Conversation

@xmikus01
Copy link
Contributor

@xmikus01 xmikus01 commented Jun 21, 2021 •
edited
Loading

Description

Alpine just released its v3.14 version.

Closes #1496.

Motivation and Context

For more information, see release blog post: https://alpinelinux.org/posts/Alpine-3.14.0-released.html

Testing Details

N/A

Example Output(if appropriate)

N/A

Types of changes

  • Documentation
  • Version change (Update, remove or add more Node.js versions)
  • Variant change (Update, remove or add more variants, or versions of variants)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Others (non of above)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • All new and existing tests passed.

@nschonni nschonni requested a review from a team June 21, 2021 16:40
@xmikus01
Copy link
Contributor Author

xmikus01 commented Jun 24, 2021

@nschonni @SimenB This PR is blocked by #1500:

gpg: keyserver receive failed: No name
gpg: keyserver receive failed: No name
gpg: keyserver receive failed: No keyserver available

ttshivers
ttshivers approved these changes Jul 4, 2021
View reviewed changes
Copy link
Member

@ttshivers ttshivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this

@PeterDaveHello
Copy link
Member

PeterDaveHello commented Jul 5, 2021

@xmikus01 as #1500 was resolved in #1510, would you like to rebase added-alpine3.14 branch base on the latest main branch, so that we can pass the CI and get it merged? Thanks!

@xmikus01
Copy link
Contributor Author

xmikus01 commented Jul 5, 2021

Build is broken for Alpine variants, see #1514.

@xmikus01 xmikus01 force-pushed the added-alpine3.14 branch 2 times, most recently from 1dc7a22 to f9781c8 Compare July 6, 2021 13:27
@bricss
Copy link

bricss commented Jul 7, 2021

Looks like NODE_VERSIONs might be bumped to the latest versions available atm ⏲️

@PeterDaveHello
Copy link
Member

PeterDaveHello commented Jul 7, 2021

The build issue seem to be fixed?

nschonni
nschonni reviewed Jul 7, 2021
View reviewed changes
@nschonni
Copy link
Member

nschonni commented Jul 7, 2021

@PeterDaveHello yes, this has the fix from #1510 applied already

@xmikus01 xmikus01 force-pushed the added-alpine3.14 branch from f9781c8 to 26a3ec0 Compare July 8, 2021 10:52
@xmikus01
Copy link
Contributor Author

xmikus01 commented Jul 8, 2021

@PeterDaveHello @nschonni Ready to merge.

@nschonni nschonni merged commit 702fcf0 into nodejs:main Jul 8, 2021
@nodejs-github-bot nodejs-github-bot mentioned this pull request Jul 8, 2021
Merged
@github-actions
Copy link

github-actions bot commented Jul 8, 2021

Created PR on the official-images repo (docker-library/official-images#10506). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub.

@xmikus01 xmikus01 deleted the added-alpine3.14 branch October 7, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ttshivers ttshivers ttshivers approved these changes

@nschonni nschonni nschonni approved these changes

@SimenB SimenB SimenB approved these changes

@PeterDaveHello PeterDaveHello PeterDaveHello approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Alpine 3.14 image

6 participants

@xmikus01 @PeterDaveHello @bricss @nschonni @ttshivers @SimenB